Allow setting different namespace root #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the root for any loaded namespace is the loader instance. But someone may want to set autoloads on a nother (named or anonymous) module, and there is no reason Im should not support this. With this change, it is now possible to pass a "root" when initializing a loader. This root (a module) is then used in place of the loader itself as the root of the (auto)loaded namespace.
|
I need to update the readme and add changelog entry etc, but otherwise this should be a simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the root for any loaded namespace is the loader instance. But someone may want to set autoloads on another (named or anonymous) module, and there is no reason Im should not support this.
With this change, it is now possible to pass a
rootwhen initializing a loader. This root (a module) is then used in place of the loader itself as the root of the (auto)loaded namespace.e.g.
Now, autoloads are set on
modinstead ofloader. PassingObjectasroothere makes Im act like Zeitwerk.